Remove unneeded anchor events #24474
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
There was a problem hiding this comment.
Pull Request Overview
This PR removes unneeded anchor event callbacks to simplify the AnchorSet API and associated tests. The changes include updating test cases to no longer subscribe to and log events for childrenChanged and subtreeChanging, and refactoring the AnchorSet implementation to stop emitting these events.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/dds/tree/src/test/tree/anchorSet.spec.ts | Updated test title and callbacks to remove childrenChanged and subtreeChanging expectations. |
| packages/dds/tree/src/test/shared-tree/treeCheckout.spec.ts | Removed subscription and log verification for subtreeChanging events. |
| packages/dds/tree/src/core/tree/anchorSet.ts | Removed event definitions and emission for childrenChanged, subtreeChanging, and subtreeChanged events. |
Comments suppressed due to low confidence (3)
packages/dds/tree/src/test/tree/anchorSet.spec.ts:449
- Ensure that the test expectations and log assertions correctly reflect the current behavior now that 'childrenChanged' and 'subtreeChanging' events have been removed.
it("triggers childrenChanging, treeChanging, and afterDestroy callbacks", () => {
packages/dds/tree/src/test/shared-tree/treeCheckout.spec.ts:90
- Verify that all log expectations have been updated to exclude references to the removed 'subtreeChanging' events so that the test accurately reflects the new event behavior.
const unsubscribe = anchorNode.events.on("childrenChanging", () => log.push("change"));
packages/dds/tree/src/core/tree/anchorSet.ts:747
- Confirm that removing the fallback emission on 'childrenChanging' (which previously used an alternative event emitter) will not negatively affect dependent logic expecting a fallback path.
this.maybeWithNode((p) => p.events.emit("childrenChanging", p));
yann-achard-MS
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unneeded anchor events
Reviewer Guidance
The review process is outlined on this wiki page.